Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Added pa11y, set up testing for twig, scss reloading #95

Merged
merged 7 commits into from
Nov 21, 2018
Merged

Conversation

evanmwillhite
Copy link
Contributor

@evanmwillhite evanmwillhite commented Nov 16, 2018

Add pa11y accessibility testing on save of twig and scss files.

Pull Request Deployment

If you've never set up Emulsify Gulp for local testing, do the following:

  • Step 1: Clone the Emulsify Gulp repo locally and run npm link
  • Step 2: Go to your Emulsify installation and run npm link emulsify-gulp

To Test:

  • Install a fresh copy of Emulsify
  • Save any existing twig or sass files. Verify that you are now getting accessibility feedback in the console
  • Do the same for an existing copy, preferably in a client project (you'll need to run step 2 above inside your theme).

@evanmwillhite
Copy link
Contributor Author

evanmwillhite commented Nov 20, 2018

Roadmap identified in practice group:

  • Add to config: hideElements, standard, and maybe rootElement, actions, any others?
  • Add separate issue for pa11y CI tests (maybe use pa11y-ci). Possibly can do this as a separate PR but maybe release single release? Add to build task by default.
  • Set defaults to includeNotices: true and includeWarnings: true
  • Add notes at the bottom of the console output to let developers know they can tweak those in config if needed
  • Make a new major release, document in wiki and possibly on README. Push to all communication channels.

// eslint-disable-next-line
const pa11yCli = require('pa11y-reporter-cli');

// function pa11yRun(pa11yUrl, config) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this commented out code be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, done. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants