New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favor trailing dot for multi-line chaining of methods #1

Closed

tbreier wants to merge 1 commit into master from method_chaning_style

tbreier commented May 19, 2015

Pro:
- Current code is written like this
- Consistent with ||, , etc.
- From include '.' on first line of multiline chained method invocations rubocop/ruby-style-guide#176 (comment):
  Leading dots are an antipattern:
  - They require the continuation to be present at precisely next line. (I.e. you cannot put more than one in-line comment in between.)
  - Most importantly, code written with leading dots cannot be copied and pasted to irb/pry.
Contra:
- looks weird, less organized
- Commenting out works with leading dots


          Favor trailing dot for multi-line chaining of methods

fed6497

tbreier mentioned this pull request

Use leading dots for multi-line method chaining #4

Merged

Author

tbreier commented Jun 5, 2015

Decided to do #4 instead.

tbreier closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet