Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure explicit tls roots for tonic client #157

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

declark1
Copy link
Collaborator

Related to (not fully understood) breaking change in tonic 0.12.0 #1731, which is causing connection timeout in our TLS-enabled tonic clients.

Signed-off-by: declark1 <daniel.clark@ibm.com>
Copy link
Collaborator

@evaline-ju evaline-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works again! LGTM - thanks for the fix!

@declark1 declark1 merged commit 4a74fb3 into foundation-model-stack:main Aug 13, 2024
2 checks passed
@declark1 declark1 deleted the explicit-tls-roots branch August 13, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants