chore: Update dependencies #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- del v6.0.0 - folder-hash v4.0.0 - fs-extra v9.0.1 - github v14.0.0 - gulp-babel v8.0.0 Fixes fossasia#2168
|
@iamareebjamal this won't run the travis ci build as I have changed only the package.json. I have checked there is no build corresponding to this PR as well. |
|
You need to update yarn.lock as well and travis build should still work |
|
@iamareebjamal Doesn't yarn also look up to package.json like npm does for installation of dependencies of a specific version? Don't you think yarn.lock must be in gitignore like package-lock.json? Please do let me know if I am missing something. |
|
No. There is no point of yarn.lock if it is not committed to the repository. Please read more about it. It is a security and dependency pinning feature |
…stv14.0.0 - gulp-babel has a peer dependency on babel/core v7.0.0 - ftp-deploy has peer dependency on promise-ftp-common v1.1.5 - github v14.0.0 has been renamed to octokit/rest v14.0.0 - Change the module "github" to "@octokit/rest" in deploy.js while importing
…onal check with null for copyerr as fs-extra new version returns undefined instead of null
- Latest version of fs-extra sets err as undefined instead of null
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| const distHelper = require('./dist.js'); | |||
| const fs = require('fs'); | |||
| const Github = require('github'); | |||
| const Github = require('@octokit/rest'); | |||
There was a problem hiding this comment.
Nothing else needed to be changed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
developmentbranch.Short description of what this resolves:
Update all the outdated dependencies referring to https://david-dm.org/fossasia/open-event-wsgen. The update resulted in some breaking changes which required the codebase to change.
Changes proposed in this pull request:
Fixes #2168