Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and re-enable sponsor link test #2362

Closed
iamareebjamal opened this issue Oct 13, 2020 · 2 comments · Fixed by #2372
Closed

Fix and re-enable sponsor link test #2362

iamareebjamal opened this issue Oct 13, 2020 · 2 comments · Fixed by #2372
Labels
Codeheat Priority: High testing

Comments

@iamareebjamal
Copy link
Member

A test in test/sessionEventAndCoC.js was disabled to fix the build in #2361

Fix the logic and re-enable the test
@dhruvjain99
Copy link
Contributor

@iamareebjamal there is one sponsor link endpoint which has been removed by the sponsor. There are two ways either we can remove the sponsor form the event site data or we can test for Mozilla All Hands 2017 event site broken sponsor links. Let me know what do I need to do I'll do it.

@iamareebjamal
Copy link
Member Author

Second option

dhruvjain99 added a commit to dhruvjain99/open-event-wsgen that referenced this issue Oct 30, 2020
@dhruvjain99
Ref: Re-enable checking broken links in sponsors section for MozillaA…
c02d060 
…llHands2017 event

- Earlier the test was on FossasiaSummit2017 in which one sponsor link was broken so the test failed
- Now we are checking for MozillaAllHands2017 so the test is moved after eventPage visits the MozillaAllHands2017 site

Fixes fossasia#2362
@dhruvjain99 dhruvjain99 mentioned this issue Oct 30, 2020
Merged
iamareebjamal pushed a commit that referenced this issue Oct 30, 2020
@dhruvjain99
chore: Re-enable checking broken links in sponsors section (#2372)
acdbc05 
- Earlier the test was on FossasiaSummit2017 in which one sponsor link was broken so the test failed
- Now we are checking for MozillaAllHands2017 so the test is moved after eventPage visits the MozillaAllHands2017 site

Fixes #2362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Codeheat Priority: High testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Re-enable checking broken links in sponsors section dhruvjain99/open-event-wsgen
2 participants
@iamareebjamal @dhruvjain99