removed pyreadline dependency (#1800)

* removed pyreadline dependency

* replaced pyreadline by pyreadline3

* Update setup.py

examples/mimikatz.py

@@ -38,12 +38,6 @@
     logging.critical("Warning: You don't have any crypto installed. You need pycryptodomex")
     logging.critical("See https://pypi.org/project/pycryptodomex/")
 
-# If you wanna have readline like functionality in Windows, install pyreadline
-try:
-  import pyreadline as readline
-except ImportError:
-  import readline
-
 
 mimikatz_intro = r"""Type help for list of commands"""
 

examples/ntfs-read.py

@@ -34,11 +34,6 @@
 import argparse
 import cmd
 import ntpath
-# If you wanna have readline like functionality in Windows, install pyreadline
-try:
-  import pyreadline as readline
-except ImportError:
-  import readline
 from six import PY2, text_type
 from datetime import datetime
 from impacket.examples import logger

impacket/examples/smbclient.py

@@ -35,12 +35,6 @@
 import charset_normalizer as chardet
 
 
-# If you wanna have readline like functionality in Windows, install pyreadline
-try:
-  import pyreadline as readline
-except ImportError:
-  import readline
-
 class MiniImpacketShell(cmd.Cmd):
     def __init__(self, smbClient, tcpShell=None, outputfile=None):
         #If the tcpShell parameter is passed (used in ntlmrelayx),

requirements.txt

@@ -8,4 +8,4 @@ pyOpenSSL==24.0.0
 ldap3>=2.5,!=2.5.2,!=2.5.0,!=2.6
 ldapdomaindump>=0.9.0
 flask>=1.0
-pyreadline;sys_platform == 'win32'
+pyreadline3;sys_platform == 'win32'

setup.py

@@ -70,7 +70,7 @@ def read(fname):
 
     install_requires=['pyasn1>=0.2.3', 'pyasn1_modules', 'pycryptodomex', 'pyOpenSSL==24.0.0', 'six', 'ldap3>=2.5,!=2.5.2,!=2.5.0,!=2.6',
                       'ldapdomaindump>=0.9.0', 'flask>=1.0', 'setuptools', 'charset_normalizer'],
-    extras_require={'pyreadline:sys_platform=="win32"': [],
+    extras_require={':sys_platform=="win32"': ['pyreadline3'],
                     },
     classifiers=[
         "Programming Language :: Python :: 3.12",