Add "formElement" props to allow any element to be render as a form #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would |
rkuykendall
reviewed
Jan 14, 2021
API.md
Outdated
| @@ -293,6 +294,20 @@ class MyForm extends React.Component { | |||
| With the `preventExternalInvalidation` the input will not be invalidated though it has an error when | |||
| `updateInputsWithError()` or an `invalidate` callback is called. | |||
|
|
|||
| ### <a id="as">as</a> | |||
| By default Formy render the form with the HTML `form` element. | |||
There was a problem hiding this comment.
Suggested change
| By default Formy render the form with the HTML `form` element. | |
| By default Formsy render the form with the HTML `form` element. |
|
@rkuykendall Yes you're right, formElement is much more understandable. I made the changes |
ThibautMarechal
changed the title
rkuykendall
approved these changes
Jan 20, 2021
rkuykendall
pushed a commit
that referenced
this pull request
Jan 21, 2021
…599) * add as props to render any elements * add documentation * rename 'as' props to 'formElement' Co-authored-by: Thibaut Maréchal <t.marechal@evs.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
( Allow overriding the element to render as form )
Tests run directly on the source code and all dist changes are computed and committed during Formsy release.