Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revalidate form when dynamic inputs are added, fixes #550 #551

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Conversation

felixmosh
Copy link
Contributor

This PR fixes #550 while preserves the speed of mounting a form with many inputs.

I've added a test for this bug.
And an additional test for mounting multiple inputs.

Without initial render optimization
image

With the bug
image

With the fix
image

@felixmosh felixmosh merged commit 82a789a into master Aug 27, 2020
@rkuykendall rkuykendall deleted the fix-550 branch August 29, 2020 15:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic added inputs not triggers form revalidation
1 participant