made sure Wrapper deprecation warning is shown only once #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkuykendall
approved these changes
Nov 22, 2017
|
@MilosRasic We should cut a release once a fix for #41 is complete. I figure since that's a bug fix for our existing 1.1.x we should allow people to upgrade without removing depreciations, right? If so, we should merge this. |
|
@rkuykendall exactly. Feel free to press the button. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented this because of cases like:
Please review and if it's ok let's merge only if we want to do another 1.1.x release. If we end up going straight to 1.2 at some point then we can just remove the Wrapper named export.