Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HTMLFormElement attributes to be passed to a Formsy form #193

Merged
merged 2 commits into from
Jul 11, 2019

Conversation

twisty
Copy link
Member

@twisty twisty commented Jul 11, 2019

Allow HTMLFormElement attributes to be passed to a Formsy form

This fixes a use case where I wanted to set a class attribute on the <form /> output by Formsy.

This works fine at runtime (it is passed through in nonFormsyProps), however passing a className prop is not allowed in the FormsyProps definition.

This PR expands the FormsyProps definition to explicitly allow passing HTMLFormElement attributes that are passed through (nonFormsyProps) to the <form />.

@twisty
Copy link
Member Author

twisty commented Jul 11, 2019

@rkuykendall Should I build and commit /dist, too?

@rkuykendall
Copy link
Member

@twisty Nope! 😄Jest now runs off the source, and the project is automatically built and committed on npm deploy!

@rkuykendall rkuykendall merged commit 081af76 into formsy:master Jul 11, 2019
@twisty twisty deleted the allow-form-attributes branch September 4, 2019 08:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants