Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead assignment #105

Open
lyonel2017 opened this issue Feb 20, 2024 · 1 comment
Open

Dead assignment #105

lyonel2017 opened this issue Feb 20, 2024 · 1 comment

Comments

@lyonel2017
Copy link

I think the following assignment is dead code and can be removed:

libjade/src/crypto_kem/kyber/common/amd64/ref/reduce.jinc

Line 42 in 0daf13f

r = t;

@tfaoliveira
Copy link
Member

thanks for reporting, I will mention this issue in https://github.com/formosa-crypto/hakyber
and push a fix

tfaoliveira added a commit that referenced this issue Feb 21, 2024
@tfaoliveira
https://github.com/formosa-crypto/libjade/issues/105
7362bf2
@tfaoliveira tfaoliveira mentioned this issue Feb 21, 2024
Open
tfaoliveira-sb added a commit that referenced this issue Mar 11, 2024
@tfaoliveira-sb
Merge pull request #107 from formosa-crypto/fix/kyber-dead-code
c1c7516 
#105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tfaoliveira @lyonel2017