Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for content-disposition:inline to S3 signed URL on GET /documents/{id}/url #52

Closed
reganwolfrom opened this issue Oct 1, 2022 · 0 comments
Closed

Add option for content-disposition:inline to S3 signed URL on GET /documents/{id}/url #52

reganwolfrom opened this issue Oct 1, 2022 · 0 comments
Assignees
@mfriesen
Labels
enhancement New feature or request
Milestone
v1.8.9

Comments

@reganwolfrom
Copy link
Member

Currently, S3 signed URL defaults to content-disposition:attachment;filename=BLAH, and this does not always allow for rendering of files within the browser.

If we had a parameter such as ?inline=true on GET /documents/{id}/url that provided content-disposition:inline;filename=BLAH, this may allow us to render the documents inline (as the content type allows) more easily
@reganwolfrom reganwolfrom added the enhancement New feature or request label Oct 1, 2022
mfriesen pushed a commit that referenced this issue Oct 1, 2022
@formkiqMike
#52 - Add option for content-disposition:inline to S3 signed URL on G…
74d7d17 
…ET /documents/{id}/url
mfriesen pushed a commit that referenced this issue Oct 1, 2022
@formkiqMike
#52 - Add option for content-disposition:inline to S3 signed URL on G…
eb83c89 
…ET /documents/{id}/url
@mfriesen mfriesen added this to the v1.8.9 milestone Oct 15, 2022
mfriesen added a commit that referenced this issue Oct 16, 2022
@mfriesen
v1.8.9 (#58)
5f2e9f4 
* Added POST /queryFulltext API

* #52 - Add option for content-disposition:inline to S3 signed URL on GET /documents/{id}/url

* Added ability to create Global Indexes
* fixes

* Added https://www.onlyoffice.com/ API support

* #56 - Document Content-Length is set to NULL when using PATCH /documents/{documentId}

* #53 - Adding new "path" tag after deleting previous "path" tag gives 200 but tag does not appear to exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfriesen mfriesen

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.8.9
Development

No branches or pull requests
2 participants
@mfriesen @reganwolfrom