fix: only read multiple custom labels files once during conversion #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
reviewed
Jul 15, 2024
mshanemc
reviewed
Jul 15, 2024
|
QA: ✅ works as expected on customer repro (using npsp) trying to break stuff |
mshanemc
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple custom labels files are in a project, only read them once during conversion. There was a bug where the first custom labels file found was read once but any others that existed in the project were read every time a child CustomLabel was encountered. This would result in out of memory errors when that 2nd or 3rd labels file contained thousands of labels.
forcedotcom/cli#2939
@W-16096068@