Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subregion flags for Mexico (MX) #29

Merged
merged 2 commits into from
Sep 11, 2017
Merged

Add subregion flags for Mexico (MX) #29

merged 2 commits into from
Sep 11, 2017

Conversation

behnam
Copy link
Collaborator

@behnam behnam commented Sep 11, 2017

Update regions script to use Spanish (es) names of subregions and
convert them to ASCII.

All new image sources added by this change fall under the exempt from
Copyright group, based on Mexican laws.

For four cases that the WP page title was different, add new records to
ASLIAS-WP, and also create redirects on WP. In the future, if the
redirects stay stable, we can drop the aliases.

Run download script and add html/svg/png files.

Update regions script to use Spanish (`es`) names of subregions and
convert them to ASCII.

All new image sources added by this change fall under the exempt from
Copyright group, based on Mexican laws.

For four cases that the WP page title was different, add new records to
ASLIAS-WP, and also create redirects on WP. In the future, if the
redirects stay stable, we can drop the aliases.
Run download script and add html/svg/png files.
@behdad behdad merged commit ad3aa10 into fonttools:gh-pages Sep 11, 2017
@behnam behnam deleted the mx branch September 11, 2017 22:00
@behnam behnam self-assigned this Sep 11, 2017
@behnam behnam requested a review from behdad September 11, 2017 22:02
@Kanjilearner817
Copy link

The flag shown for the State of Mexico is the national flag. Here's the correct flag: https://commons.wikimedia.org/wiki/File:Flag_of_Mexico_(state).svg

@behnam
Copy link
Collaborator Author

behnam commented Sep 11, 2017

Good catch, @Kanjilearner817! I'll fix it in a min.

behnam added a commit to behnam/region-flags that referenced this pull request Sep 11, 2017
`MX-MEX` was pointing to the same source as `MX`, because of the name
overlap. Override in `ALIASES-WP`.

See <fonttools#29 (comment)>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants