Add an exception for the missing storage field #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girijaasoni
changed the title
girijaasoni
force-pushed
the
validate-datastore
branch
from
655e955
to
3c3f72c
Compare
|
A bit of context: currently the system does not allow empty storage field, and fails the creation of a VM with "Invalid path" error, which is not indicative at all. |
chris1984
reviewed
Apr 3, 2024
|
LGTM code-wise. |
chris1984
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Works fine on my devel box, ACK. Will get a new release made. Thanks @girijaasoni
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed solution for #2186114
I think creating a host without mentioning the storage pod or the datastore should not be permitted. Adding validation is one way to go but achieving that is extremely difficult. Adding an exception is a much simpler approach to it.
I'm open for any other ideas to approach this problem. Please feel free to share your thoughts on this.
cc: @ShimShtein