Fixes vmware 8 u2 iso detach #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manisha15
force-pushed
the
fix_vmware_8_iso_detach
branch
from
80679fc
to
e828009
Compare
|
Will start to test and get it added to our board |
Manisha15
force-pushed
the
fix_vmware_8_iso_detach
branch
from
e828009
to
3acd096
Compare
To fix the vmware 8 issue, you need to have theforeman/foreman_bootdisk#158, too |
ekohl
reviewed
Feb 27, 2024
Manisha15
force-pushed
the
fix_vmware_8_iso_detach
branch
from
3acd096
to
fe60ac6
Compare
Manisha15
force-pushed
the
fix_vmware_8_iso_detach
branch
from
fe60ac6
to
0556d2e
Compare
|
Thanks! Will get this tested today/tomorrow then look at the code again |
chris1984
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Code looks fine, thanks for addressing Ewouds comments. Test failures are unrelated, have a card on the board to get them fixed.
Work with PR and bootdisk_pr
Before:
Traceback from production.log
==> /var/log/foreman/production.log <==
2024-03-04T14:37:50 [W|app|ed510f37] Failed to detach ISO image from CDROM drive of instance sean-horth.lab.eng.rdu2.redhat.com: InvalidPowerState: The attempted operation cannot be performed in the current state (Powered on).
2024-03-04T14:37:50 [I|app|ed510f37] Backtrace for 'Failed to detach ISO image from CDROM drive of instance sean-horth.lab.eng.rdu2.redhat.com: InvalidPowerState: The attempted operation cannot be performed in the current state (Powered on).' error (RbVmomi::Fault): InvalidPowerState: The attempted operation cannot be performed in the current state (Powered on).
ed510f37 | /usr/share/gems/gems/rbvmomi2-3.7.0/lib/rbvmomi/vim/Task.rb:15:in `wait_for_completion'Screenshot showing error in VMware:
With PR, no traceback in production log and we can see good tasks in VMware:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.