Fixes #272 - New NIC ID decrements from initial random int to avoid collisions #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chris1984 Hi, any chance that you could take a look at this one? |
|
@Ron-Lavi yeah I will take a look today. |
chris1984
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some discussion at #273 (merged), the code to generate a new NIC ID will now generate a new random base ID once for each new VM, deriving new NIC IDs from this base by decrementing it for each new NIC.
E.g. for a new VM the new random base ID may be -26789.
The first NIC will have NIC ID=-26790.
Second NIC will have NIC ID=-26791.
...and so on.