Allow clone vm from different datacenter #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if datacenter option is in clone arguments, add vm's datacenter as template_datacenter, as vm to use as template may be in different datacenter
ezr-ondrej
reviewed
Oct 6, 2020
There was a problem hiding this comment.
Great addition @scambra ! 👍
Just one nit, let me know what you think :)
Love the dead code deletion! please more of that xD
| @@ -104,14 +110,11 @@ def vm_clone(options = {}) | |||
| # Option handling | |||
| options = vm_clone_check_options(options) | |||
|
|
|||
| # Added for people still using options['path'] | |||
| template_path = options['path'] || options['template_path'] | |||
There was a problem hiding this comment.
👍 I bet there is more dead code like this xD
Co-authored-by: Ondřej Ezr <ezrik12@gmail.com>
ezr-ondrej
changed the title
|
Do you need this released fast or can it wait a while? |
|
Starting to kick off regression tests |
|
I can wait, I can use repository in gemfile until it's released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if datacenter option is in clone arguments, add vm's datacenter as template_datacenter, as vm to use as template may be in different datacenter