Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ENS160 digital multi-gas sensor with multiple IAQ data (TVOC, eCO2, AQI) #371

Merged
merged 5 commits into from
Jul 9, 2024

Conversation

linucks
Copy link
Contributor

@linucks linucks commented Jun 10, 2024

Based on adafruit-circuitpython-ens160

@BenjiU
Copy link
Collaborator

BenjiU commented Jun 20, 2024

Hi @linucks, may you please fix the lint warnings in your ens160 module, so we can complete the PR?

************* Module mqtt_io.modules.sensor.ens160
mqtt_io/modules/sensor/ens160.py:74:0: C0301: Line too long (119/100) (line-too-long)
mqtt_io/modules/sensor/ens160.py:103:0: C0301: Line too long (101/100) (line-too-long)
mqtt_io/modules/sensor/ens160.py:115:0: C0301: Line too long (132/100) (line-too-long)
mqtt_io/modules/sensor/ens160.py:117:0: C0301: Line too long (118/100) (line-too-long)
mqtt_io/modules/sensor/ens160.py:118:0: C0301: Line too long (120/100) (line-too-long)

Thanks!

@linucks
Copy link
Contributor Author

linucks commented Jun 20, 2024

@BenjiU I've made the changes and it looks like everything is passing now.

Btw, is there any developer documentation? I ran:

poetry install
poetry run pylint -d fixme mqtt_io
poetry run mypy --show-error-codes --strict --no-warn-unused-ignores mqtt_io

which I got from the CI file.

It'd be helpful if there was a document detailing the steps to go through to submit a PR and I couldn't find one when I looked.

@linucks
Copy link
Contributor Author

linucks commented Jul 1, 2024

Hi. What's happened to this PR? Is there a reason that it hasn't been merged?

@BenjiU BenjiU merged commit 88cff85 into flyte:develop Jul 9, 2024
5 checks passed
@linucks linucks deleted the ens160 branch July 10, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants