Add Support for Sunxi Linux Boards #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabys77
changed the title
flyte
previously requested changes
May 24, 2020
There was a problem hiding this comment.
Thanks for the module! The Sunxi stuff all looks good to me.
However, I'm apprehensive about merging the BME280 module, since it seems to me like code that should exist in its own external package specifically for the BME280 as opposed to something the pi-mqtt-gpio project should be supporting. Having done a quick search, would it be possible to use a library such as https://github.com/pimoroni/bme280-python instead?
|
Hi flyte. I've followed your advise and and I change bme280 module using this library: Fabio |
BenjiU
dismissed
flyte’s stale review
Changes were made as requested - can't compelte it on behalf of flyte ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for boards that use Sunxi Linux like some Olimex and Cubieboard.
I've tested only GPIO on Cubieboard2 (armbian 5.8)