Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop sending terrain on nd data if the sim stopped or is paused #87

Merged
merged 5 commits into from
Jul 9, 2023
Merged

fix: stop sending terrain on nd data if the sim stopped or is paused #87

merged 5 commits into from
Jul 9, 2023

Conversation

svengcz
Copy link
Contributor

@svengcz svengcz commented Jul 7, 2023

This PR introduces system event handling of MSFS to check the current state and avoid sending data if the sim is not ready to receive it.

@svengcz svengcz marked this pull request as ready for review July 8, 2023 18:46
Saschl
Saschl approved these changes Jul 9, 2023
View reviewed changes
Copy link
Contributor

@Saschl Saschl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see comment :)

apps/server/src/terrain/communication/simconnect.ts Outdated Show resolved Hide resolved
@svengcz svengcz merged commit a392b07 into main Jul 9, 2023
@svengcz svengcz deleted the bugfix/memoryLeak branch July 9, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saschl Saschl Saschl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svengcz @Saschl