Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Size field on archived artifacts #597

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Implement Size field on archived artifacts #597

merged 1 commit into from
Mar 1, 2022

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Feb 28, 2022

This adds a Size field to Artifacts, which reflects the number of bytes
written to the artifact when it's being archived.

Supersedes #585

This adds a Size field to Artifacts, which reflects the number of bytes
written to the artifact when it's being archived.

Signed-off-by: Kevin McDermott <bigkevmcd@gmail.com>
@hiddeco hiddeco added the enhancement New feature or request label Feb 28, 2022
@darkowlzz
Copy link
Contributor

Posting what it looks like:

status:
  artifact:
    checksum: 733e3acdb8c41ffe264dc4d3fa73d43277072da5c33a63b185680dd4249ea163
    lastUpdateTime: "2022-02-28T20:59:01Z"
    path: gitrepository/default/podinfo/132f4e719209eb10b9485302f8593fc0e680f4fc.tar.gz
    revision: master/132f4e719209eb10b9485302f8593fc0e680f4fc
    size: 75340
    url: http://localhost:9090/gitrepository/default/podinfo/132f4e719209eb10b9485302f8593fc0e680f4fc.tar.gz

Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hiddeco hiddeco merged commit bae1b10 into main Mar 1, 2022
@hiddeco hiddeco deleted the artifact-size branch March 1, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants