Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies; switch to go-git/go-git and pkg/tar #1105

Merged
merged 2 commits into from
May 26, 2023

Conversation

aryan9600
Copy link
Member

@aryan9600 aryan9600 commented May 24, 2023

Bumps:

  • github.com/fluxcd/pkg/git => v0.12.2
  • github.com/fluxcd/pkg/git/gogit => v0.11.1
  • github.com/fluxcd/pkg/gittestserver => v0.8.4
  • github.com/fluxcd/pkg/oci => v0.27.0 (fix: Using kubelet identity to access ACR OCI charts #1071)
  • github.com/fluxcd/pkg/sourceignore => v0.3.4

Switch from fluxcd/go-git to go-git/go-git v5.7.0, as all changes made to our fork have been contributed back upstream. Furthermore, switch from fluxcd/pkg/untar to fluxcd/pkg/tar v0.2.0 as the former has been deprecated.

@aryan9600 aryan9600 marked this pull request as draft May 24, 2023 19:55
@aryan9600 aryan9600 force-pushed the bump-git branch 2 times, most recently from dbd3890 to d4a5a87 Compare May 25, 2023 10:29
@stefanprodan stefanprodan added area/git Git related issues and pull requests dependencies Pull requests that update a dependency labels May 25, 2023
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @aryan9600 🎖️

@aryan9600
Copy link
Member Author

Waiting for a new pkg/oci tag to be available with the changes made in fluxcd/pkg#560 and fluxcd/pkg#563.

* github.com/fluxcd/pkg/git => v0.12.2
* github.com/fluxcd/pkg/git/gogit => v0.11.1
* github.com/fluxcd/pkg/gittestserver => v0.8.4
* github.com/fluxcd/pkg/oci => v0.27.0
* github.com/fluxcd/pkg/sourceignore => v0.3.4

Switch from `fluxcd/go-git`to `go-git/go-git` v5.7.0, as all changes made
to our fork have been contributed back upstream.

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Switch from `fluxcd/pkg/untar` to `fluxcd/pkg/tar` v0.2.0 as the former
has been deprecated. Ref: https://github.com/fluxcd/pkg/blob/main/untar/go.mod#L1

Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@aryan9600 aryan9600 marked this pull request as ready for review May 26, 2023 08:17
@somtochiama
Copy link
Member

This pull request also fixes this issue: #1071 with the update to pkg/oci.

@stefanprodan stefanprodan merged commit 6c05a55 into fluxcd:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git related issues and pull requests dependencies Pull requests that update a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using kubelet identity to access ACR OCI charts
3 participants