-
Notifications
You must be signed in to change notification settings - Fork 262
Conversation
33c2dac
to
667fe44
Compare
hack/update/generate-crds.sh
Outdated
paths=./pkg/apis/... | ||
mv ${CRD_DIR}/helm.fluxcd.io_helmreleases.yaml ${CRD_DIR}/helmrelease.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a weird behavior that the file will be different when the crd version is set. I do not know why this happens and I could not figure out how to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think an option may be to use output:stdout
(instead of output:dir=...
) and then write it directly to the file, instead of moving one around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the tip, makes it a lot cleaner. I did however have to trim the first two lines of the generated CRD as the new line and ---
caused other issues.
@@ -1,24 +1,27 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this some code gen error? We have an empty yaml doc then v1beta1
CRD, shouldn't it be v1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch this issue was caused by some extra new lines in the crd generation. Should be fixed now by removing them.
I do not have access to the Circle CI tests so I cant see why the tests are failing. Running |
The whole end-to-end test suite fails due to the operator not installing correctly. |
Ah missed that, looks like I should be able to run e2e tests locally to debug this? |
Should work with |
837ef88
to
c60f01a
Compare
43603d7
to
dc1be73
Compare
@hiddeco so the E2E tests works now. I was looking at the totally wrong location, the issue was never in the tests but rather that values were not being parsed properly. Had to understand the tests before I could understand that. Can you have a look now? |
Signed-off-by: Philip Laine <philip.laine@gmail.com> Signed-off-by: Kingdon Barrett <yebyen@gmail.com>
I incorporated this PR in #623 and will rebase it now manually to match that, so it closes out when that one is merged. |
dc1be73
to
9a4e753
Compare
It rebased cleanly 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @phillebaba 🍻, and thanks @kingdonb for driving the release 🚋
This change will update the CRD version from v1beta1 to v1 in preparation for k8s v1.22. I have documented the tests that I have run to determine the different behaviors of helm-operator in different scenarios. Hopefully it is easy to follow along and understand what has been tested.