[WIP] An edgy test case with Istio example

[errordeveloper]

While playing with Istio, I've encotered an issue with Flux failing to parse a manifest that contains 1 service and 3 deployments.

The reviews service is defind as part of a larger multi-doc manifest. In order to enable it with Istion sidecars, one has to use istioctl kube-inject, and only after that it becomes consumable by Flux. I've checked in the output of istioctl kube-inject into a repo of my own and split the app into smaller multi-docs, and hooked it up to Flux (using v1.0.0-beta).

Flux tripped over this with an obscure error message:

ts=2017-08-09T14:58:11Z caller=loop.go:132 component=sync-loop err="Service default/reviews: running kubectl: error: error validating \"STDIN\": error validating data: field spec.template.spec.containers[0].name for v1.Container is required; if you choose to ignore these errors, turn validation off with --validate=false; Deployment default/reviews-v1: yaml: line 1: mapping values are not allowed in this context"

I've test the manifest using kubectl apply and it worked just fine.

I then broke the manifest into 4 (1 for the service, and one for each of the deployments), and that worked fine with Flux (see reviews*.yaml).
I've then combined deployments into one file, and that gave me a new error:

ts=2017-08-09T16:34:53Z caller=loop.go:132 component=sync-loop err="Deployment default/reviews-v1: running kubectl: The Deployment \"reviews-v3\" is invalid: \n* spec.template.metadata.labels: Invalid value: map[string]string(nil): `selector` does not match template `labels`\n* spec.template.spec.containers: Required value"

So I realised something must be a litte odd here.

In this PR I've added a test case with large multi-doc and after I've made some trivial updates in the tests, I've discovered that we end-up with a bit of a mess:

• a fragment of PodSpec for one of the review-v? deployments
• a top fragment of reviews-3 deployment (there is also separate full-copy of it)
• a top fragment of reviews-2 deployment

[squaremo]

Good to have this extra test case. Can you reduce it to just the thing(s) that upset the parsing? (And I guess we don't need it to be istio-specific, which would remove the licensing concern)

[errordeveloper]

I'd like to understand what exactly causes this behaviour, and I don't know enough yet. I agree, however I think it's possible that a significantly large manifest may be the key to this behaviour.

…

On Thu, Aug 10, 2017, 10:52 AM Michael Bridgen ***@***.***> wrote: Good to have this extra test case. Can you reduce it to just the thing(s) that upset the parsing? (And I guess we don't need it to be istio-specific, which would remove the licensing concern) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#697 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPWS6JgRM05mTZ2D8R9SH1ZSjMoejwRks5sWtLkgaJpZM4OybR2> .

[squaremo]

a significantly
large manifest may be the key to this behaviour.

#826 increased the buffer used for scanning multidocument YAML files, if that was indeed the problem here.

I'm going to close this PR, but please do raise an issue if you can still reproduce the problem, @errordeveloper.