This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
[WIP] An edgy test case with Istio example #697
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing with Istio, I've encotered an issue with Flux failing to parse a manifest that contains 1 service and 3 deployments.
The reviews service is defind as part of a larger multi-doc manifest. In order to enable it with Istion sidecars, one has to use
istioctl kube-inject
, and only after that it becomes consumable by Flux. I've checked in the output ofistioctl kube-inject
into a repo of my own and split the app into smaller multi-docs, and hooked it up to Flux (using v1.0.0-beta).Flux tripped over this with an obscure error message:
I've test the manifest using
kubectl apply
and it worked just fine.I then broke the manifest into 4 (1 for the service, and one for each of the deployments), and that worked fine with Flux (see
reviews*.yaml
).I've then combined deployments into one file, and that gave me a new error:
So I realised something must be a litte odd here.
In this PR I've added a test case with large multi-doc and after I've made some trivial updates in the tests, I've discovered that we end-up with a bit of a mess:
PodSpec
for one of thereview-v?
deploymentsreviews-3
deployment (there is also separate full-copy of it)reviews-2
deployment