This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Remove telemetry #3636
Merged
Remove telemetry #3636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingdonb
force-pushed
the
remove-telemetry
branch
2 times, most recently
from
2d87f63
to
6d294c8
Compare
Closed
pjbgf
approved these changes
Aug 27, 2022
We are removing all of the telemetry code as it is not needed, and being on by default it may be contrary to CNCF policies around telemetry. * remove check function With no telemetry, there's no need for these function implementations or this syscall in this package anymore. We need to preserve the cadence of checkpoint.go to avoid disturbing any thing that would constitute a breaking change, but basically all of the underlying behavior of check can go away, since every Flux v1 version is out of date every time, we don't need any remote service or lookup to tell if an update is needed. (It's always needed) Users should follow the link to upgrade (eg. the migration guide) Signed-off-by: Kingdon Barrett <kingdon@weave.works> Update pkg/checkpoint/checkpoint.go Signed-off-by: Kingdon Barrett <kingdon@weave.works> Co-authored-by: Stefan Prodan <stefan.prodan@gmail.com>
kingdonb
force-pushed
the
remove-telemetry
branch
from
a270d46
to
743c6ce
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3633
Make a clean break from
"github.com/weaveworks/go-checkpoint"without any salient change to behavior or outputs