This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Go mod updates #3512
Closed
Go mod updates #3512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingdonb
force-pushed
the
go-mod-updates
branch
2 times, most recently
from
c80ffda
to
552dc19
Compare
|
It looks like the breaking change was in since it was apparently not the issue here! (Tests passed in 552dc19) |
kingdonb
force-pushed
the
go-mod-updates
branch
3 times, most recently
from
3c8ac9e
to
e2552eb
Compare
kingdonb
changed the title
kingdonb
pushed a commit
to kingdonb/flux
that referenced
this pull request
Jul 26, 2021
kingdonb
force-pushed
the
go-mod-updates
branch
from
e2552eb
to
aea2e0a
Compare
* Update github.com/shurcooL/vfsgen commit hash to 0d455de * Update golang.org/x/oauth2 commit hash to a41e5a7 * Update golang.org/x/sys commit hash to 0f9fa26 * Update golang.org/x/time commit hash to 1f47c86 * Update module github.com/Masterminds/semver/v3 to v3.1.1 * Update module github.com/gorilla/mux to v1.8.0 * Update module github.com/instrumenta/kubeval to v0.16.1 * Update module github.com/aws/aws-sdk-go to v1.40.7 * Update module github.com/pkg/term to v1 * Update module github.com/prometheus/client_golang to v1.11.0 * Update module k8s.io/apiextensions-apiserver to v0.21.3 * Update module github.com/google/go-github/v28 to v37 * Update module github.com/whilp/git-urls to v1 * Update module k8s.io/klog to v2 * Update module github.com/cheggaaa/pb/v3 to v3.0.8 * Update module github.com/evanphx/json-patch to v4.11.0 * Update module github.com/go-kit/kit to v0.11.0 * Update module github.com/spf13/cobra to v1.2.1 * Update module github.com/fluxcd/helm-operator to v1.4.0 * Update module github.com/imdario/mergo to v0.3.12 * Update module github.com/google/go-containerregistry to v0.5.1 Signed-off-by: Kingdon Barrett <kingdon@weave.works> Signed-off-by: Kingdon Barrett <yebyen@gmail.com>
Signed-off-by: Kingdon Barrett <kingdon@weave.works> Signed-off-by: Kingdon Barrett <yebyen@gmail.com>
kingdonb
force-pushed
the
go-mod-updates
branch
from
aea2e0a
to
8663c34
Compare
kingdonb
changed the title
|
Closing in favor of #3537 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is equivalent to 06f868c, minus f16dfe7
I don't (yet) want to enable the renovatebot on the fluxcd/flux repo proper, as it can generate a lot of noise, but it would be good to get some of the updates it recommended into a release.
The PRs were merged individually at kingdonb/flux however many tests failed because of Docker Hub rate limiting and likely also because my account isn't provisioned with a paid CircleCI membership. Some of the test failures I experienced were likely due to breaking changes, that I reverted and squashed out of the history, you won't see them here.
I will decline to include any major version bumps unless there's a compelling reason for it, as they would have to be carefully evaluated to be sure we haven't leaked any of their breaking changes through to our users.
I worked the PR over for a while and I believe I have incorporated all of the non-breaking upgrades from dependencies. 👍