Add support for Google Chat alerts #953
Conversation
Signed-off-by: fpinna <fplkid@gmail.com>
Signed-off-by: fpinna <fplkid@gmail.com>
Signed-off-by: fpinna <fplkid@gmail.com>
|
Just want to give you a heads up that @stefanprodan is out on holidays and this PR probably won't be reviewed before he is back (in two weeks). |
Thank you for your feedback. |
Signed-off-by: fpinna <fplkid@gmail.com>
|
Was this tested? I really doubt it works since the gchat is missing from the Notifier Factory. |
Signed-off-by: fpinna <fplkid@gmail.com>
Sorry, my bad. I made mistakes with my last commit. |
| @@ -1191,6 +1191,7 @@ spec: | |||
| - msteams | |||
| - discord | |||
| - rocket | |||
| - gchat | |||
There was a problem hiding this comment.
Please add this to artifacts/flagger/crd.yaml then run make crd and commit all changes.
Signed-off-by: fpinna <fplkid@gmail.com>
pkg/notifier/factory.go
Outdated
| @@ -52,6 +52,8 @@ func (f Factory) Notifier(provider string) (Interface, error) { | |||
| n, err = NewRocket(f.URL, f.ProxyURL, f.Username, f.Channel) | |||
| case "msteams": | |||
| n, err = NewMSTeams(f.URL, f.ProxyURL) | |||
| case "gchat": | |||
| n, err = NewMSTeams(f.URL, f.ProxyURL) | |||
Codecov Report
@@ Coverage Diff @@
## main #953 +/- ##
==========================================
+ Coverage 56.91% 56.97% +0.05%
==========================================
Files 71 73 +2
Lines 5861 5924 +63
==========================================
+ Hits 3336 3375 +39
- Misses 2030 2048 +18
- Partials 495 501 +6
Continue to review full report at Codecov.
|
Signed-off-by: fpinna <fplkid@gmail.com>
Add google chat alerting support