Adjusted Nginx ingress canary headers on init and promotion #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2021 14:45
Signed-off-by: Iaroslav Vorozhko <iaroslav.vorozhko@mcmakler.de>
Signed-off-by: Iaroslav Vorozhko <iaroslav.vorozhko@mcmakler.de>
vorozhko
force-pushed
the
nginx-ingress-cleanup
branch
from
9ee487f
to
41481c1
Compare
Codecov Report
@@ Coverage Diff @@
## main #907 +/- ##
==========================================
+ Coverage 56.76% 56.95% +0.18%
==========================================
Files 69 69
Lines 5704 5710 +6
==========================================
+ Hits 3238 3252 +14
+ Misses 1983 1975 -8
Partials 483 483
Continue to review full report at Codecov.
|
|
@vorozhko can you please enable the webhook in NGINX e2e tests to verify that this works? Thanks |
|
Default ingress nginx helm has webhook enabled by default. |
|
So how come the test passes without this PR? Maybe the version we use in e2e doesn’t have the webhook? |
…ook after canary promotion Signed-off-by: Iaroslav Vorozhko <iaroslav.vorozhko@mcmakler.de>
vorozhko
force-pushed
the
nginx-ingress-cleanup
branch
from
ad4e53d
to
d7999e6
Compare
|
Added Nginx e2e tests to cover validation webhook case. |
|
Thank you too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted canary headers after canary deployment is promoted
It resolves validation webhook issue