linkerd: update prometheus URL based on the latest 2.10 changes #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Linkerd 2.10, The Prometheus instance moved into the `viz` extension which is installed separately from the core control-plane. This means that the prometheus now exists in the `linkerd-viz` namespace by default unless overriden. This PR updates the URl to reflect the same Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
42 tasks
|
@Pothulapati does this means the tutorial here will no longer work? https://docs.flagger.app/tutorials/linkerd-progressive-delivery I guess we need to specify the commands to install Linkerd and Prometheus in there |
|
Can you please update the e2e tests also https://github.com/fluxcd/flagger/tree/main/test/linkerd |
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
|
@Pothulapati can you please rebase with main, I've fixed the failing e2e test. |
|
Thanks, now it fails like I've expected it: |
|
@stefanprodan Yep. Should I make this PR wait for the next stable release i.e |
|
@Pothulapati thanks for this, can you please squash the commits? |
This commit updates the linkerd version to `2.10`, along with the install script to download the arm version. It also updates the install script and metricsTempalte to install and use the viz Prometheus respectively. Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
Pothulapati
force-pushed
the
tarun/l5d-2.10
branch
from
c29e3d2
to
4a66a28
Compare
stefanprodan
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Linkerd 2.10, The Prometheus instance moved into the
vizextension which is installed separately from the core
control-plane. This means that the prometheus now exists in
the
linkerd-viznamespace by default unless overriden.This PR updates the URl to reflect the same
Signed-off-by: Tarun Pothulapati tarunpothulapati@outlook.com