Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alerts section to Canary CRD schema #794

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Add alerts section to Canary CRD schema #794

merged 2 commits into from
Jan 28, 2021

Conversation

stefanprodan
Copy link
Member

Fix: #793

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@BarrieShieh
Copy link

hi, i think also need some definitions like username channel in AlertProvider too. https://github.com/fluxcd/flagger/blob/main/charts/flagger/crds/crd.yaml#L1077-L1150

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Copy link
Member Author

@BarrieShieh good catch! Thank you

@codecov-io
Copy link

Codecov Report

Merging #794 (52cec59) into main (4f54901) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
+ Coverage   56.53%   56.61%   +0.07%     
==========================================
  Files          67       67              
  Lines        5391     5403      +12     
==========================================
+ Hits         3048     3059      +11     
- Misses       1881     1882       +1     
  Partials      462      462              
Impacted Files Coverage Δ
pkg/canary/deployment_controller.go 64.63% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f54901...52cec59. Read the comment docs.

@stefanprodan stefanprodan merged commit 0c4dd94 into main Jan 28, 2021
@stefanprodan stefanprodan deleted the alert-crd branch January 28, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation Error when apply the configs
3 participants