Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor routing management #72

Merged
merged 6 commits into from
Mar 5, 2019
Merged

Refactor routing management #72

merged 6 commits into from
Mar 5, 2019

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Mar 5, 2019

This PR adds router.Interface with two implementations: one for Kubernetes ClusterIP services and the other for Istio virtual services.

Fix: #75

@codecov-io
Copy link

codecov-io commented Mar 5, 2019

Codecov Report

Merging #72 into master will decrease coverage by 1.08%.
The diff coverage is 77.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   55.61%   54.53%   -1.09%     
==========================================
  Files           9       13       +4     
  Lines        1397     1533     +136     
==========================================
+ Hits          777      836      +59     
- Misses        483      557      +74     
- Partials      137      140       +3
Impacted Files Coverage Δ
pkg/controller/controller.go 6.96% <ø> (+0.25%) ⬆️
pkg/router/factory.go 0% <0%> (ø)
pkg/controller/scheduler.go 39.56% <64.1%> (+0.23%) ⬆️
pkg/router/istio.go 80% <80%> (ø)
pkg/router/kubernetes.go 90.47% <90.47%> (ø)
pkg/loadtester/server.go 0% <0%> (ø)
pkg/loadtester/runner.go 82.97% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 535a92e...ac544ee. Read the comment docs.

@stefanprodan stefanprodan merged commit 74f07cf into master Mar 5, 2019
@stefanprodan stefanprodan deleted the router branch March 5, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants