Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installers for kustomize >= 3.6.0 #646

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Fix installers for kustomize >= 3.6.0 #646

merged 2 commits into from
Jul 9, 2020

Conversation

stefanprodan
Copy link
Member

The current installers are broken for kustomize >= 3.6.0:

$ kustomize build github.com/weaveworks/flagger//kustomize/kubernetes?ref=v1.0.0 | kubectl apply -f -

Error: accumulating resources: accumulateFile "accumulating resources from '../base/flagger/': evalsymlink failure on '/private/var/folders/77/3y6x_p2j2g9fspdkzjbm5_s40000gn/T/kustomize-948385415/base/flagger' : lstat /private/var/folders/77/3y6x_p2j2g9fspdkzjbm5_s40000gn/T/kustomize-948385415/base: no such file or directory", loader.New "Error loading ../base/flagger/ with git: url lacks host: ../base/flagger/, dir: evalsymlink failure on '/private/var/folders/77/3y6x_p2j2g9fspdkzjbm5_s40000gn/T/kustomize-948385415/base/flagger' : lstat /private/var/folders/77/3y6x_p2j2g9fspdkzjbm5_s40000gn/T/kustomize-948385415/base: no such file or directory, get: invalid source string: ../base/flagger/"

This PR adds the https:// prefix to the base URL and removes the //:

 $ kustomize build https://github.com/weaveworks/flagger/kustomize/kubernetes?ref=v1.0.0 | kubectl apply -f -

namespace/flagger-system created
customresourcedefinition.apiextensions.k8s.io/alertproviders.flagger.app configured
customresourcedefinition.apiextensions.k8s.io/canaries.flagger.app configured
customresourcedefinition.apiextensions.k8s.io/metrictemplates.flagger.app configured
serviceaccount/flagger created
serviceaccount/flagger-prometheus created
clusterrole.rbac.authorization.k8s.io/flagger configured
clusterrole.rbac.authorization.k8s.io/flagger-prometheus created
clusterrolebinding.rbac.authorization.k8s.io/flagger configured
clusterrolebinding.rbac.authorization.k8s.io/flagger-prometheus created
configmap/flagger-prometheus-5hdhmkhck9 created
service/flagger-prometheus created
deployment.apps/flagger created
deployment.apps/flagger-prometheus created

Copy link
Collaborator

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

kustomize/README.md Outdated Show resolved Hide resolved
Co-authored-by: Takeshi Yoneda <cz.rk.t0415y.g@gmail.com>
@stefanprodan stefanprodan merged commit 0e2858d into master Jul 9, 2020
@stefanprodan stefanprodan deleted the fix-kustomize branch July 9, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants