Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement App Mesh v1beta2 timeout #611

Merged
merged 3 commits into from
Jun 8, 2020
Merged

Implement App Mesh v1beta2 timeout #611

merged 3 commits into from
Jun 8, 2020

Conversation

stefanprodan
Copy link
Member

This PR adds support for setting AppMesh listener/route timeouts with canary.spec.service.timeout.

Ref: #577

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2020

Codecov Report

Merging #611 into master will increase coverage by 0.00%.
The diff coverage is 55.55%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #611   +/-   ##
=======================================
  Coverage   55.00%   55.00%           
=======================================
  Files          62       62           
  Lines        5303     5330   +27     
=======================================
+ Hits         2917     2932   +15     
- Misses       1959     1967    +8     
- Partials      427      431    +4     
Impacted Files Coverage Δ
pkg/router/appmesh_v1beta2.go 84.63% <55.55%> (-2.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c367e65...0715e1c. Read the comment docs.

@stefanprodan stefanprodan merged commit bebfac8 into master Jun 8, 2020
@stefanprodan stefanprodan deleted the appmesh-timeout branch June 8, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants