loadtester: add return cmd output option #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
changed the title
There was a problem hiding this comment.
@jacobsin have you tested this changes with Flagger? does it log the output?
|
@jacobsin can you please rebase with master and solve the conflict? PS. The change you need to make is |
|
@jacobsin you need to rebase with master so that only your changes are included in this PR. |
|
@stefanprodan merge now and using the |
|
@jacobsin you need to rebase with upstream master. |
jacobsin
force-pushed
the
300-loadtester-return-cmd-output-optionally
branch
from
ad10154
to
29c31e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #300
making loadtester response with cmd output when
metadata.returnCmdOutput= "true", useful to explicitly show all tests that has been run for audit purpose