Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement metrics server override #342

Merged
merged 3 commits into from
Oct 17, 2019
Merged

Implement metrics server override #342

merged 3 commits into from
Oct 17, 2019

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Oct 17, 2019 •
edited
Loading

This PR makes the Prometheus URL configurable on a per canary basis.

Example:

apiVersion: flagger.app/v1alpha3
kind: Canary
metadata:
  name: podinfo
spec:
  provider: appmesh
  metricsServer: http://prometheus-operator-prometheus.monitoring:9090

Fix: #341

@stefanprodan stefanprodan merged commit f372523 into master Oct 17, 2019
@stefanprodan stefanprodan deleted the prom-config branch October 17, 2019 14:24
@stefanprodan stefanprodan mentioned this pull request Oct 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Prometheus URL configurable on a per canary basis
1 participant
@stefanprodan