Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details to Slack messages #14

Merged
merged 4 commits into from
Dec 6, 2018
Merged

Add details to Slack messages #14

merged 4 commits into from
Dec 6, 2018

Conversation

stefanprodan
Copy link
Member

  • attach canary analysis metadata to init/start messages
  • add rollback reason to failed canary messages
  • add Alermanager example to alerting docs

Fix: #12

- attach canary analysis metadata to init/start messages
- add rollback reason to failed canary messages
@codecov-io
Copy link

codecov-io commented Dec 6, 2018

Codecov Report

Merging #14 into master will decrease coverage by 1.2%.
The diff coverage is 22.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   45.45%   44.24%   -1.21%     
==========================================
  Files           6        6              
  Lines         880      904      +24     
==========================================
  Hits          400      400              
- Misses        425      449      +24     
  Partials       55       55
Impacted Files Coverage Δ
pkg/controller/controller.go 6.96% <4.16%> (-1.13%) ⬇️
pkg/controller/scheduler.go 26.5% <63.63%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f6a30f...4584733. Read the comment docs.

@stefanprodan stefanprodan merged commit 6372c7d into master Dec 6, 2018
@stefanprodan stefanprodan deleted the slack branch December 6, 2018 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants