Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gloo): Use correct route table name in case service name was overwritten #1300

Conversation

mdolinin
Copy link
Contributor

@mdolinin mdolinin commented Oct 25, 2022

Steps to reproduce bug:

  • Create Canary resource with service.name set and provider gloo
    For example:
  provider: gloo 
  service:
    name: podinfo-flagger
  • flagger will create RouteTable with name podinfo-flagger
  • But then in logs it will error that query error: routetables.gateway.solo.io for name podinfo

This PR will use same func and names for GetRoutes as for Reconcile.

PR contains:

…written

Signed-off-by: mdolinin <dmo.builder@gmail.com>
@mdolinin mdolinin force-pushed the fix/gloo-non-default-service-name-corretly-get-routes branch from 563a82c to 4c0b2be Compare October 25, 2022 01:38
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdolinin can you please bump Gloo Helm chart version to latest in e2e tests here: https://github.com/fluxcd/flagger/blob/main/test/gloo/install.sh#L5

Signed-off-by: mdolinin <dmo.builder@gmail.com>
@mdolinin
Copy link
Contributor Author

@mdolinin can you please bump Gloo Helm chart version to latest in e2e tests here: https://github.com/fluxcd/flagger/blob/main/test/gloo/install.sh#L5

@stefanprodan Updated to the latest stable 1.12.31

…from >1.12.x

Signed-off-by: mdolinin <dmo.builder@gmail.com>
@mdolinin
Copy link
Contributor Author

@stefanprodan can you please approve CI workflow to execute. I have made necessary change to test. And updated PR description. Thanks.

@mdolinin
Copy link
Contributor Author

@stefanprodan Can we re-run [e2e-test (nginx)] (https://github.com/fluxcd/flagger/actions/runs/3322155362/jobs/5490871791#logs)? I could not understood how my last commit impacted that.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @mdolinin 🏅

@stefanprodan stefanprodan merged commit a7df345 into fluxcd:main Oct 26, 2022
@mdolinin mdolinin deleted the fix/gloo-non-default-service-name-corretly-get-routes branch October 26, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants