If HPA is set, it uses HPA minReplicas when scaling up the canary #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andylibrian
force-pushed
the
scale-from-zero-use-hpa-minreplicas
branch
from
1ecbba4
to
835fa22
Compare
Codecov Report
@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
- Coverage 54.74% 54.68% -0.06%
==========================================
Files 81 81
Lines 6949 6965 +16
==========================================
+ Hits 3804 3809 +5
- Misses 2550 2559 +9
- Partials 595 597 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aryan9600
requested changes
Aug 15, 2022
|
Thanks for the review, @aryan9600. I have added the v2 HPA support as you suggested. Do you have any other comment? |
aryan9600
requested changes
Aug 16, 2022
andylibrian
force-pushed
the
scale-from-zero-use-hpa-minreplicas
branch
from
72f7295
to
3df93b8
Compare
aryan9600
requested changes
Aug 17, 2022
andylibrian
force-pushed
the
scale-from-zero-use-hpa-minreplicas
branch
from
066b314
to
1c33544
Compare
…specified Without this, the canary replicas are updated twice: to 1 replica then after a few seconds to the value of HPA minReplicas. In some cases, when updated to 1 replica (before updated by HPA controller to the minReplicas), it's considered ready: 1 of 1 (readyThreshold 100%), and the canary weight is advanced to receive traffic with less capacity than expected. Co-Authored-By: Joshua Gibeon <joshuagibeon7719@gmail.com> Co-authored-by: Sanskar Jaiswal <hey@aryan.lol> Signed-off-by: Andy Librian <andylibrian@gmail.com>
andylibrian
force-pushed
the
scale-from-zero-use-hpa-minreplicas
branch
from
1c33544
to
8b11551
Compare
aryan9600
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the canary replicas are updated twice: to 1 replica then after a few seconds to the value of HPA minReplicas.
In some cases, when updated to 1 replica (before updated by HPA controller to the minReplicas), it's considered ready: 1 of 1 (readyThreshold 100%), and the canary weight is advanced to receive traffic with less capacity than expected.
Similar PR previously: #1110
Signed-off-by: Andy Librian andylibrian@gmail.com