Avoid setting owner refs if the service mesh/ingress is on a different cluster #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1183 +/- ##
==========================================
- Coverage 56.91% 54.95% -1.96%
==========================================
Files 79 79
Lines 6631 6640 +9
==========================================
- Hits 3774 3649 -125
- Misses 2301 2418 +117
- Partials 556 573 +17
Continue to review full report at Codecov.
|
stefanprodan
reviewed
May 5, 2022
pkg/router/kuma.go
Outdated
| Annotations: filterMetadata(metadata.Annotations), | ||
| }, | ||
| Spec: trSpec, | ||
| Mesh: meshName, | ||
| } | ||
| if kr.setOwnerRefs { |
There was a problem hiding this comment.
According to #1170 we shouldn't set OwnerReference on TrafficRoutes since they are global objects while Canaries are namespaced. Right now Kubernetes issues warning events. Please remove this OwnerReference from the Kuma router.
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
stefanprodan
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if the host of the cluster where Flagger is installed is different from the cluster where the ingress/service mesh is installed, and sets OwnerRefs on created resources accordingly.
Fix: #694
Signed-off-by: Sanskar Jaiswal sanskar.jaiswal@weave.works