Use nginx controller canary metrics #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L3o-pold
force-pushed
the
hotfix/use-nginx-controller-canary-metrics
branch
2 times, most recently
from
c6fae82
to
814ca3c
Compare
There was a problem hiding this comment.
@L3o-pold we need to change the tests here https://github.com/fluxcd/flagger/blob/main/test/nginx/test-canary.sh to use the builtin metrics instead of podinfo exported ones.
L3o-pold
force-pushed
the
hotfix/use-nginx-controller-canary-metrics
branch
5 times, most recently
from
bd723a7
to
ce1ec6d
Compare
L3o-pold
force-pushed
the
hotfix/use-nginx-controller-canary-metrics
branch
3 times, most recently
from
25f1502
to
798b792
Compare
|
@stefanprodan could you trigger a re-run on failed tests? Seems not related to the PR. |
Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com>
L3o-pold
force-pushed
the
hotfix/use-nginx-controller-canary-metrics
branch
from
798b792
to
7d2f3de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #382