Skip to content

Commit

Permalink
remove todo
Browse files Browse the repository at this point in the history
  • Loading branch information
yuval-k committed Apr 23, 2019
1 parent 4d7fae3 commit 5ba27c8
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions pkg/router/supergloo_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,9 @@ func TestSuperglooRouter_Sync(t *testing.T) {
if err := routingRuleClient.Register(); err != nil {
t.Fatal(err.Error())
}
// TODO(yuval-k): un hard code this
targetMesh := solokitcore.ResourceRef{
Namespace: "supergloo-system",
Name: "yuval",
Name: "mesh",
}
router := NewSuperglooRouterWithClient(context.TODO(), routingRuleClient, targetMesh, mocks.logger)
err = router.Reconcile(mocks.canary)
Expand Down Expand Up @@ -61,10 +60,9 @@ func TestSuperglooRouter_SetRoutes(t *testing.T) {
if err := routingRuleClient.Register(); err != nil {
t.Fatal(err.Error())
}
// TODO(yuval-k): un hard code this
targetMesh := solokitcore.ResourceRef{
Namespace: "supergloo-system",
Name: "yuval",
Name: "mesh",
}
router := NewSuperglooRouterWithClient(context.TODO(), routingRuleClient, targetMesh, mocks.logger)

Expand Down Expand Up @@ -126,10 +124,9 @@ func TestSuperglooRouter_GetRoutes(t *testing.T) {
if err := routingRuleClient.Register(); err != nil {
t.Fatal(err.Error())
}
// TODO(yuval-k): un hard code this
targetMesh := solokitcore.ResourceRef{
Namespace: "supergloo-system",
Name: "yuval",
Name: "mesh",
}
router := NewSuperglooRouterWithClient(context.TODO(), routingRuleClient, targetMesh, mocks.logger)
err = router.Reconcile(mocks.canary)
Expand Down

0 comments on commit 5ba27c8

Please sign in to comment.