Skip to content

Commit

Permalink
use name.namespace instead of namespace.name
Browse files Browse the repository at this point in the history
  • Loading branch information
yuval-k committed Apr 25, 2019
1 parent d196bb2 commit 5279f73
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- checkout
- run: test/e2e-kind.sh
- run: test/e2e-supergloo.sh
- run: test/e2e-build.sh supergloo:supergloo-system.test
- run: test/e2e-build.sh supergloo:test.supergloo-system
- run: test/e2e-tests.sh canary

workflows:
Expand Down
6 changes: 3 additions & 3 deletions pkg/router/supergloo.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,14 @@ func NewSuperglooRouter(ctx context.Context, provider string, flaggerClient clie

// remove the supergloo: prefix
provider = strings.TrimPrefix(provider, "supergloo:")
// split namespace.name :
// split name.namespace:
parts := strings.Split(provider, ".")
if len(parts) != 2 {
return nil, fmt.Errorf("invalid format for supergloo provider")
}
targetMesh := solokitcore.ResourceRef{
Namespace: parts[0],
Name: parts[1],
Namespace: parts[1],
Name: parts[0],
}
return NewSuperglooRouterWithClient(ctx, routingRuleClient, targetMesh, logger), nil
}
Expand Down

0 comments on commit 5279f73

Please sign in to comment.