Use deep copy when updating the virtual service routes

fluxcd · Jan 16, 2019 · 10c2bde · 10c2bde
1 parent 4bf3b70
commit 10c2bde
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/pkg/controller/router.go b/pkg/controller/router.go
@@ -276,13 +276,15 @@ func (c *CanaryRouter) SetRoutes(
 		}
 		return fmt.Errorf("VirtualService %s.%s query error %v", targetName, cd.Namespace, err)
 	}
-	vs.Spec.Http = []istiov1alpha3.HTTPRoute{
+
+	vsCopy := vs.DeepCopy()
+	vsCopy.Spec.Http = []istiov1alpha3.HTTPRoute{
 		{
 			Route: []istiov1alpha3.DestinationWeight{primary, canary},
 		},
 	}
 
-	vs, err = c.istioClient.NetworkingV1alpha3().VirtualServices(cd.Namespace).Update(vs)
+	vs, err = c.istioClient.NetworkingV1alpha3().VirtualServices(cd.Namespace).Update(vsCopy)
 	if err != nil {
 		return fmt.Errorf("VirtualService %s.%s update failed: %v", targetName, cd.Namespace, err)