Skip to content

Commit

Permalink
Compare only hosts and gateways
Browse files Browse the repository at this point in the history
  • Loading branch information
carlossg committed Feb 19, 2019
1 parent 1925f99 commit 0c0ebae
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/controller/router.go
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ func (c *CanaryRouter) createVirtualService(cd *flaggerv1.Canary) error {
return fmt.Errorf("VirtualService %s.%s create error %v", targetName, cd.Namespace, err)
}
c.logger.With("canary", fmt.Sprintf("%s.%s", cd.Name, cd.Namespace)).Infof("VirtualService %s.%s created", virtualService.GetName(), cd.Namespace)
} else if !reflect.DeepEqual(virtualService.Spec, newSpec) {
} else if !reflect.DeepEqual(virtualService.Spec.Hosts, newSpec.Hosts) || !reflect.DeepEqual(virtualService.Spec.Gateways, newSpec.Gateways) {
virtualService.Spec = newSpec
c.logger.Debugf("Updating VirtualService %s.%s", virtualService.GetName(), cd.Namespace)
_, err = c.istioClient.NetworkingV1alpha3().VirtualServices(cd.Namespace).Update(virtualService)
Expand Down

0 comments on commit 0c0ebae

Please sign in to comment.