-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compass App: Search form screen #2353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the list of continents is short and will remain the same, I think we should put it on the server-side as well, even if for teaching purposes.
(besides, image URLs may change, so it is good to have control over that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I prefer to use fakes instead of mocks when possible.
In this case, it was the easiest way to mock the GoRouter
implementation and test that the route is called correctly with all query parameters.
Part of the implementation of the Compass App for the Architecture sample.
Merge to
compass-app
This PR introduces the Search Form Screen, in which users can select a region, a date range and the number of guests.
The feature is split in 5 different widgets, each one depending on the
SearchFormViewModel
. The architecture follows the same patterns implemented in the previous PR #2342TODO later on:
Demo
Screencast.from.2024-07-12.14-30-48.webm
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.