Include log metadata in logs table. #8419
Merged
+414
−214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
commented
Oct 9, 2024
| ); | ||
| } | ||
|
|
||
| extension SizeExtension on MetadataChip { |
There was a problem hiding this comment.
moved from metadata.dart
kenzieschmoll
commented
Oct 9, 2024
| @@ -167,3 +168,46 @@ class _LoggingTableRowState extends State<LoggingTableRow> { | |||
| ); | |||
| } | |||
| } | |||
|
|
|||
| class WhenMetaDataChip extends MetadataChip { | |||
There was a problem hiding this comment.
moved from metadata.dart. I expect we will remove this v2 code eventually.
kenzieschmoll
changed the title
elliette
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR displays log metadata as chips in the logs table. This includes log level (severity), which we had the data for but were not using until this PR. Fixes #1108. Fixes #6796
Work towards #7703.