Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move analytics factories to constructors #8399

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Move analytics factories to constructors #8399

merged 1 commit into from
Oct 3, 2024

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Oct 3, 2024

Fix an old TODO RE fixed dart-lang/sdk#46967

@kevmoo kevmoo requested a review from a team as a code owner October 3, 2024 22:41
@kevmoo kevmoo requested review from kenzieschmoll and removed request for a team October 3, 2024 22:41
@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 3, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 3, 2024
Copy link

auto-submit bot commented Oct 3, 2024

auto label is removed for flutter/devtools/8399, due to - The status or check suite Verify PR Release Note Requirements has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmoo kevmoo merged commit 77eae8f into master Oct 3, 2024
27 of 28 checks passed
@kevmoo kevmoo deleted the use_constructors branch October 3, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

js interop fragile with non-external factory constructor
2 participants