Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor label keys in RuntimeInfo #4271

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

omerap12
Copy link
Member

Ⅰ. Describe what this PR does

Refactor label key functions from the Runtime struct by moving them to the utils package.

Ⅱ. Does this pull request fix one issue?

As part of #978, I'm splitting this into separate PRs, starting with refactoring label key functions from the Runtime struct and moving them to the utils package.

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

No new tests are required, as the existing tests already cover the functionality and the function signatures remain unchanged.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Copy link

fluid-e2e-bot bot commented Aug 13, 2024

Hi @omerap12. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cheyang
Copy link
Collaborator

cheyang commented Aug 14, 2024

@omerap12 thanks for your contribution. Could you check why the project check is failed? https://github.com/fluid-cloudnative/fluid/actions/runs/10376419144/job/28728332638?pr=4271

@omerap12
Copy link
Member Author

@omerap12 thanks for your contribution. Could you check why the project check is failed? https://github.com/fluid-cloudnative/fluid/actions/runs/10376419144/job/28728332638?pr=4271

Yes , of course

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@omerap12
Copy link
Member Author

omerap12 commented Aug 14, 2024

Hey @cheyang , fixed . ( lint errors don't related to me I think)
Do you need me to rebase my commits?

Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
LGTM and thank you for your great refactoring @omerap12 !

BTW, @cheyang do we have any plan to remove codes related to such deprecated labels? It has been several published versions since we deprecated them. I think now it would be okay to remove them.

@omerap12
Copy link
Member Author

Sure no problem @TrafalgarZZZ :)

@cheyang
Copy link
Collaborator

cheyang commented Aug 19, 2024

/lgtm LGTM and thank you for your great refactoring @omerap12 !

BTW, @cheyang do we have any plan to remove codes related to such deprecated labels? It has been several published versions since we deprecated them. I think now it would be okay to remove them.

Thank you for your suggestion. It's fine to remove them after v1.0 releases.

@cheyang
Copy link
Collaborator

cheyang commented Aug 19, 2024

Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@fluid-e2e-bot fluid-e2e-bot bot removed the lgtm label Aug 19, 2024
@omerap12
Copy link
Member Author

@cheyang , done

Copy link

sonarcloud bot commented Aug 19, 2024

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

fluid-e2e-bot bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang
Copy link
Collaborator

cheyang commented Aug 20, 2024

Thanks very much @omerap12 .

@fluid-e2e-bot fluid-e2e-bot bot merged commit 7e23100 into fluid-cloudnative:master Aug 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants