-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor label keys in RuntimeInfo #4271
Conversation
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Hi @omerap12. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@omerap12 thanks for your contribution. Could you check why the project check is failed? https://github.com/fluid-cloudnative/fluid/actions/runs/10376419144/job/28728332638?pr=4271 |
Yes , of course |
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
Hey @cheyang , fixed . ( lint errors don't related to me I think) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure no problem @TrafalgarZZZ :) |
Thank you for your suggestion. It's fine to remove them after v1.0 releases. |
@omerap12 Please fix the project check /lint :https://github.com/fluid-cloudnative/fluid/actions/runs/10393294698/job/28780447009?pr=4271 |
Signed-off-by: Omer Aplatony <omerap12@gmail.com>
@cheyang , done |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks very much @omerap12 . |
Ⅰ. Describe what this PR does
Refactor label key functions from the
Runtime
struct by moving them to theutils
package.Ⅱ. Does this pull request fix one issue?
As part of #978, I'm splitting this into separate PRs, starting with refactoring label key functions from the
Runtime
struct and moving them to theutils
package.Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
No new tests are required, as the existing tests already cover the functionality and the function signatures remain unchanged.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews