Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-fix: check for id markers before checking for positions #889

Merged

Conversation

EagleoutIce
Copy link
Member

No description provided.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/slicing/criterion/parse.ts 86.66% <100.00%> (ø)

Copy link
Collaborator

@LukasPietzschmann LukasPietzschmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fast fix. Works like a charm ✨

@EagleoutIce EagleoutIce merged commit 5c92b46 into main Aug 9, 2024
24 checks passed
@EagleoutIce EagleoutIce deleted the 887-bug-id-criteria-detection-is-wrong-if-the-id-contains branch August 9, 2024 12:03
@EagleoutIce EagleoutIce changed the title feat-fix: check for id markers befor checking for positions feat-fix: check for id markers before checking for positions Aug 9, 2024
@EagleoutIce
Copy link
Member Author

This pull request is included in v2.0.12 (see Release v2.0.12 (Guard Against Shell-Escapes and Multi-File Support)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Id criteria detection is wrong if the id contains @
2 participants